Skip to content

Conversation

@elemoine
Copy link
Member

This tutorial requires openlayers/closure-util#53 and openlayers/closure-util#52.

This is the repo corresponding to the project built in the tutorial: https://github.com/elemoine/openlayers-closure-application/.

@bartvde
Copy link
Member

bartvde commented Apr 1, 2015

@elemoine is this ready for review or should I wait with reviewing?

@elemoine
Copy link
Member Author

elemoine commented Apr 1, 2015

The text can be reviewed. But the tutorial itself requires merging the closure-util PRs and publishing a new closure-util version. Thanks!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a minor typo in clorsure-util. It should be closure-util

@marcjansen
Copy link
Member

A very nice tutorial! I added minor comments to certain lines.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is

@elemoine elemoine changed the title (WIP) Add a "Compile Application and OpenLayers 3 Together" tutorial Add a "Compile Application and OpenLayers 3 Together" tutorial Apr 2, 2015
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with

@gberaudo
Copy link
Member

gberaudo commented Apr 2, 2015

I added some comments about typos, otherwise it looks good.

@elemoine
Copy link
Member Author

elemoine commented Apr 2, 2015

Thank you all for your comments. I think I addressed them all.

As I said in the issue description I created an openlayers-closure-application Git repository including the application built in this tutorial. The tutorial should include a link to the that repository. The repo is in my GitHub space for the moment. Do you guys think it should be moved to http://github.com/openlayers? I could also rename the repo to ol3-closure-sample-app or something.

@bartvde
Copy link
Member

bartvde commented Apr 3, 2015

hey @elemoine I think it would make sense to have that repo in the openlayers organisation if that's okay with you

@elemoine
Copy link
Member Author

elemoine commented Apr 3, 2015

Ok, thanks, I'll add it and I'll add a reference to it in the tutorial. I'm still waiting for openlayers/closure-util#53 to be reviewed and merged before merging this one.

elemoine added 2 commits April 4, 2015 22:43
Tutorial describing how to compile application and OpenLayers together.
elemoine pushed a commit that referenced this pull request Apr 4, 2015
Add a "Compile Application and OpenLayers 3 Together" tutorial
@elemoine elemoine merged commit 1c471cc into openlayers:master Apr 4, 2015
@elemoine elemoine deleted the compile-application branch April 4, 2015 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants