-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add a "Compile Application and OpenLayers 3 Together" tutorial #3441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@elemoine is this ready for review or should I wait with reviewing? |
|
The text can be reviewed. But the tutorial itself requires merging the closure-util PRs and publishing a new closure-util version. Thanks! |
doc/tutorials/compile-application.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a minor typo in clorsure-util. It should be closure-util
|
A very nice tutorial! I added minor comments to certain lines. |
doc/tutorials/compile-application.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is
doc/tutorials/compile-application.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with
|
I added some comments about typos, otherwise it looks good. |
|
Thank you all for your comments. I think I addressed them all. As I said in the issue description I created an |
|
hey @elemoine I think it would make sense to have that repo in the openlayers organisation if that's okay with you |
|
Ok, thanks, I'll add it and I'll add a reference to it in the tutorial. I'm still waiting for openlayers/closure-util#53 to be reviewed and merged before merging this one. |
Tutorial describing how to compile application and OpenLayers together.
Add a "Compile Application and OpenLayers 3 Together" tutorial
This tutorial requires openlayers/closure-util#53 and openlayers/closure-util#52.
This is the repo corresponding to the project built in the tutorial: https://github.com/elemoine/openlayers-closure-application/.