Skip to content

Conversation

@marcjansen
Copy link
Member

This PR suggests adding a protected method bindMouseOutFocusOutBlur to ol.control.Control to have fewer duplicated code.

Please review.

@fredj
Copy link
Member

fredj commented May 27, 2015

Very good idea ! The function namespace could be ol.dom instead (?)

@marcjansen
Copy link
Member Author

The function namespace could be ol.dom instead (?)

Yeah probably, but since currently only controls use it, I was tempted to put it there.

@fredj
Copy link
Member

fredj commented May 27, 2015

You're right. And since it's a non api function it could be charged later if needed

@marcjansen
Copy link
Member Author

Agreed. This is a LGTM, right 😉 ?

@fredj
Copy link
Member

fredj commented May 27, 2015

Agreed. This is a LGTM, right 😉 ?

it is

@marcjansen
Copy link
Member Author

Thanks!

marcjansen added a commit that referenced this pull request May 27, 2015
Add a method to bind button bluring on mouseout/focusout
@marcjansen marcjansen merged commit 764f821 into openlayers:master May 27, 2015
@marcjansen marcjansen deleted the control-blur-binding branch May 27, 2015 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants