Fix event type and documentation of ol.events.condition.mouseOnly #5616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahocevar
force-pushed
the
fix-mouseonly-type
branch
from
32beb23 to
3ea4873
Compare
Merged
Member
|
Does this mean |
Member
Author
|
Yes, it does. And also |
Contributor
|
can this one be merged? Get rid of the final |
ahocevar
force-pushed
the
fix-mouseonly-type
branch
from
3ea4873 to
1f689e7
Compare
Member
Author
|
Changed so |
ahocevar
force-pushed
the
fix-mouseonly-type
branch
3 times, most recently
from
078e7e1 to
5c14385
Compare
ahocevar
force-pushed
the
fix-mouseonly-type
branch
from
5c14385 to
4b68df7
Compare
Member
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we are removing
goog.asserts.*(#5600), it makes sense to fix the documentation ofol.events.condition.mouseOnlyin a better way than the hack from #5453.