Get tilePixelRatio from MVT tiles #7070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahocevar
force-pushed
the
mvt-tilepixelratio
branch
from
3be07af to
95c463c
Compare
Member
Author
|
Tests added. |
ahocevar
force-pushed
the
mvt-tilepixelratio
branch
from
95c463c to
04cef53
Compare
ahocevar
force-pushed
the
mvt-tilepixelratio
branch
from
04cef53 to
b3be7e7
Compare
ahocevar
force-pushed
the
mvt-tilepixelratio
branch
from
845b3f7 to
d4d371a
Compare
tschaub
approved these changes
Aug 3, 2017
Member
tschaub
left a comment
tschaub
left a comment
There was a problem hiding this comment.
Nice to see the extra parameter removed in the examples.
| * @return {number} Tile pixel ratio. | ||
| */ | ||
| ol.source.Tile.prototype.getTilePixelRatio = function(opt_pixelRatio) { | ||
| ol.source.Tile.prototype.getTilePixelRatio = function(pixelRatio) { |
Member
Author
There was a problem hiding this comment.
It is not strictly required, but makes things consistent again. The vector tile renderer introduced a 2nd mode of getTilePixelRatio(): when called without a pixel ratio, it was meant to return the source's tilePixelRatio, which was the 8 used in the vector tile examples.
Originally, when called with a pixel ratio, the function was meant to return the tilePixelRatio that best matches the provided pixelRatio. This is usually the provided pixelRatio for vector tiles and WMS servers that have a dpi param, or 1 for image tile sources that have no HiDPI support.
Now we're back to that original meaning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with MVT tiles, we can determine the
tilePixelRatiofrom metadata in the tile. This pull request changes things so users no longer need to configure the source with atilePixelRatiowhenol.format.MVTis used to parse tiles.