Fixed an issue where article list pages could throw an error for invalid filters#4517
Merged
StephDriver merged 3 commits intor-v1.7.xfrom Nov 28, 2024
Merged
Fixed an issue where article list pages could throw an error for invalid filters#4517StephDriver merged 3 commits intor-v1.7.xfrom
StephDriver merged 3 commits intor-v1.7.xfrom
Conversation
mauromsl
force-pushed
the
b-4497-bugfix
branch
from
f08e785 to
366675f
Compare
ajrbyers
approved these changes
Nov 28, 2024
Member
ajrbyers
left a comment
ajrbyers
left a comment
There was a problem hiding this comment.
LOOKS GOOD TO ME!
🎖️🎖️🎖️🎖️🎖️🎖️🎖️🎖️🎖️🎖️🎖️🎖️🎖️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new article list views (Relying on GenericFacetedListView) rely on GET method to apply filtering. They use a django form to render facets and filters, however the form was not being validated, leading to server errors and potential SQL injection when malformed data was sent via query parameters. We now validate all query parameters ahead of executing any queries.
closes #4497