Skip to content

Fixed a bug where rendering URL from journal A to journal B would lead to both journal codes being appended#4880

Merged
ajrbyers merged 1 commit intor-v1.8.xfrom
fix-allow-cross-journal-urls
Jul 24, 2025
Merged

Fixed a bug where rendering URL from journal A to journal B would lead to both journal codes being appended#4880
ajrbyers merged 1 commit intor-v1.8.xfrom
fix-allow-cross-journal-urls

Conversation

@mauromsl
Copy link
Copy Markdown
Member

Our stateless_site_url is not stateless because django's reverse checks the script_prefix set for the context of the request. I've changed this to invoke the resolver directly with a script prefix override and allow the site-implemented site_url to control if a prefix should be inserted to the URL or not.

@mauromsl mauromsl requested a review from joemull July 24, 2025 11:01
@joemull joemull assigned joemull and ajrbyers and unassigned joemull and ajrbyers Jul 24, 2025
@ajrbyers ajrbyers self-assigned this Jul 24, 2025
@ajrbyers ajrbyers merged commit 95256df into r-v1.8.x Jul 24, 2025
1 check passed
@ajrbyers ajrbyers deleted the fix-allow-cross-journal-urls branch July 24, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants