Skip to content

Warn editor of missing or incorrect review URL in notifications#5247

Merged
mauromsl merged 5 commits intomasterfrom
b-review_url_warning
Apr 15, 2026
Merged

Warn editor of missing or incorrect review URL in notifications#5247
mauromsl merged 5 commits intomasterfrom
b-review_url_warning

Conversation

@ajrbyers
Copy link
Copy Markdown
Member

@ajrbyers ajrbyers commented Mar 27, 2026

A confirmation modal will now pop if the review url does not match the expected url.

image

@mauromsl mauromsl requested a review from joemull March 27, 2026 15:59
@mauromsl mauromsl assigned joemull and unassigned mauromsl Mar 27, 2026
Copy link
Copy Markdown
Member

@joemull joemull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I test it out and it works fine for me. A few changes requested.

Comment thread src/review/views.py Outdated
Comment thread src/review/tests/test_views.py
Comment thread src/review/forms.py
@joemull joemull assigned ajrbyers and unassigned joemull Apr 1, 2026
@ajrbyers ajrbyers assigned joemull and unassigned ajrbyers Apr 1, 2026
@joemull joemull assigned mauromsl and unassigned joemull Apr 8, 2026
@mauromsl mauromsl merged commit 46115dd into master Apr 15, 2026
1 check failed
@mauromsl mauromsl deleted the b-review_url_warning branch April 15, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants