Skip to content

254 validation endpoint#523

Merged
philboeselager merged 8 commits intog3_masterfrom
254-validation-endpoint
Oct 25, 2022
Merged

254 validation endpoint#523
philboeselager merged 8 commits intog3_masterfrom
254-validation-endpoint

Conversation

@hornmo
Copy link
Copy Markdown
Collaborator

@hornmo hornmo commented Oct 24, 2022

No description provided.

Comment thread server/gokbg3/grails-app/services/org/gokb/ValidationService.groovy
Comment thread server/gokbg3/grails-app/services/org/gokb/ValidationService.groovy Outdated
Comment thread server/gokbg3/grails-app/services/org/gokb/ValidationService.groovy Outdated
Comment thread server/gokbg3/grails-app/services/org/gokb/ValidationService.groovy Outdated
Comment thread server/gokbg3/grails-app/services/org/gokb/ValidationService.groovy
Comment thread server/gokbg3/grails-app/services/org/gokb/ValidationService.groovy Outdated
Copy link
Copy Markdown
Contributor

@philboeselager philboeselager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. Some minor remarks.

@hornmo hornmo requested a review from philboeselager October 25, 2022 10:32
Copy link
Copy Markdown
Contributor

@philboeselager philboeselager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up.

@hornmo hornmo marked this pull request as ready for review October 25, 2022 14:11
@hornmo hornmo requested a review from philboeselager October 25, 2022 14:12
@philboeselager philboeselager merged commit 14bfb44 into g3_master Oct 25, 2022
@hornmo hornmo deleted the 254-validation-endpoint branch December 1, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants