feat(ai): comprehensive E2E test suite for all providers#48
Merged
Conversation
Replace vendor-specific E2E tests (OpenAI, Anthropic, Google, Ollama, DeepSeek, Qwen) with protocol-adapter-based tests aligned with the unified provider architecture from #34: - openai-compat.e2e.test.ts: generate, stream, tools, structured output - anthropic-compat.e2e.test.ts: generate, stream, tools - react-loop.e2e.test.ts: full ReAct cycle with real LLM - tool-calling.e2e.test.ts: tool call + result verification Tests skip gracefully when env vars are not set. CI workflow updated to use OPENAI_*/ANTHROPIC_* secrets instead of DEEPSEEK/DASHSCOPE. Closes #44
There was a problem hiding this comment.
🤖 AI Code Review
Automated review for PR #48 — informational only, does not block merge.
Checklist
| Item | Notes | |
|---|---|---|
| Type Safety | 2 use(s) of any detected |
|
| Error Handling | async code added without visible error handling | |
| ✅ | Test Coverage | 5 test file(s) updated |
| ✅ | API Consistency | No public API changes |
| ✅ | Breaking Changes | No breaking changes detected |
Stats
- 📁 Files changed: 6 (5 TypeScript)
- ➕ Lines added: 432
- 🧪 Test files updated: 5
2 check(s) need attention.
Powered by openlinkos/agent · AI PR Review workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/agent/__tests__/e2e/directory)OPENAI_*/ANTHROPIC_*secrets instead ofDEEPSEEK_API_KEY/DASHSCOPE_API_KEYNew test files
packages/ai/__tests__/e2e/openai-compat.e2e.test.tspackages/ai/__tests__/e2e/anthropic-compat.e2e.test.tspackages/agent/__tests__/e2e/react-loop.e2e.test.tspackages/agent/__tests__/e2e/tool-calling.e2e.test.tsRemoved
openai.e2e.test.ts,anthropic.e2e.test.ts,google.e2e.test.ts,ollama.e2e.test.ts,smoke.test.tsEnvironment variables
Tests are configured via
OPENAI_API_KEY,OPENAI_BASE_URL,OPENAI_MODEL,ANTHROPIC_API_KEY,ANTHROPIC_BASE_URL,ANTHROPIC_MODEL. All tests skip gracefully when env vars are not set.Test plan
pnpm testpasses — 1018 tests pass, 10 E2E tests skipped (no env vars)Closes #44