Improve cron delivery warnings and error feedback#146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
cron runoutput as broken success text like{Why
#143reported that cron creation gave no delivery warning when the workspace had no configured message channels#145reported thatRun Nowcould show an unusable success banner and that visibleerrorbadges did not explain failuresHow
cron runstdout more defensively and fall back to the generic localized success message when no human-readable message is presentlastStatuspill into an actionable control that opens run history for that jobTesting
npx vitest run src/shared/adapters/__tests__/cron.test.ts src/modules/cron/__tests__/CronPage.test.tsxnpm run builddev-browseron/cronthat the no-channel warning renders in the editor and clicking the visibleerrorpill opens run historyResolves #143
Resolves #145