Fix audit advisories and harden npm uninstall execution#150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
postcssand@langchain/coredependency paths and overridinglangsmithto a non-vulnerable versionws/wsswebsocket URL generationCloses #149.
Why
PR #148 surfaced real dependency advisories, but the code change in that PR only adds a README badge. The actual remediation needed to happen in a separate change that clears audit findings and removes the most obvious command-execution scanner signal.
How
@langchain/coreto^1.1.45in root, backend, and the managed memory pluginpostcssto^8.5.14in the web workspaceoverridesentry forlangsmithso CI resolves a fixed transitive version consistentlynpmUninstallGlobalRobust()to callexecNpmCommand()with argument arrays fornpm uninstall -gandnpm root -gwss://underhttps:andws://underhttp:Verification
npm audit --jsonnpm audit --workspace=@openclaw-manager/backend --jsonnpm audit --workspace=@openclaw-manager/web --jsonnpm run buildnpm testScreenshots