Skip to content

Fix audit advisories and harden npm uninstall execution#150

Merged
webup merged 1 commit into
developfrom
fix/security-audit-remediation
May 8, 2026
Merged

Fix audit advisories and harden npm uninstall execution#150
webup merged 1 commit into
developfrom
fix/security-audit-remediation

Conversation

@webup
Copy link
Copy Markdown
Contributor

@webup webup commented May 8, 2026

What

  • remediate the current npm audit advisories by updating the resolved postcss and @langchain/core dependency paths and overriding langsmith to a non-vulnerable version
  • harden the global uninstall flow to use argv-based npm execution instead of string shell commands
  • add regression tests for secure uninstall invocation and ws/wss websocket URL generation
  • comment on PR Add MseeP.ai badge #148 to separate the badge PR from the actual security remediation work

Closes #149.

Why

PR #148 surfaced real dependency advisories, but the code change in that PR only adds a README badge. The actual remediation needed to happen in a separate change that clears audit findings and removes the most obvious command-execution scanner signal.

How

  • bumped @langchain/core to ^1.1.45 in root, backend, and the managed memory plugin
  • bumped postcss to ^8.5.14 in the web workspace
  • added a root overrides entry for langsmith so CI resolves a fixed transitive version consistently
  • switched npmUninstallGlobalRobust() to call execNpmCommand() with argument arrays for npm uninstall -g and npm root -g
  • added a backend unit test to verify the uninstall path rejects unsupported package names and uses argv-based execution
  • added web tests proving websocket URLs resolve to wss:// under https: and ws:// under http:

Verification

  • npm audit --json
  • npm audit --workspace=@openclaw-manager/backend --json
  • npm audit --workspace=@openclaw-manager/web --json
  • npm run build
  • npm test

Screenshots

  • No UI changes.

@webup webup merged commit 50fd4f3 into develop May 8, 2026
10 checks passed
@webup webup deleted the fix/security-audit-remediation branch May 13, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remediate npm audit advisories and harden uninstall command execution

1 participant