Check that hdf5 has MPI if performing depletion with MPI#1268
Merged
paulromano merged 2 commits intoopenmc-dev:developfrom Jun 26, 2019
Merged
Check that hdf5 has MPI if performing depletion with MPI#1268paulromano merged 2 commits intoopenmc-dev:developfrom
paulromano merged 2 commits intoopenmc-dev:developfrom
Conversation
Check added in openmc/depletion/__init__.py. Without this check, the exporting of the Results to hdf5 will hang, as the second process attempts to write to a file that has already been opened on another process. This error is only raised after a full transport calculation has been run. The check raises a more helpful error directly at the import from openmc.deplete, prior to transport calculations.
paulromano
requested changes
Jun 25, 2019
Contributor
paulromano
left a comment
paulromano
left a comment
There was a problem hiding this comment.
Thanks for adding this check! This has definitely bitten others before...
drewejohnson
force-pushed
the
operator-mpi-checks
branch
2 times, most recently
from
899be20 to
830c023
Compare
Contributor
Author
|
Cleaned up the imports and some typos (hence the force pushes :/) |
paulromano
approved these changes
Jun 26, 2019
Contributor
|
Thanks @drewejohnson! |
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
Check that hdf5 has MPI if performing depletion with MPI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check added in
openmc/depletion/__init__.py. Without this check, the exporting of theResultsto hdf5 will hang, as the second process attempts to write to a file that has already been opened on another process.This error is only raised after a full transport calculation has been run. The check raises a more helpful error directly at the import from
openmc.deplete, prior to transport calculations.