Option to pass fission q values to Chain, Operator, Model#1273
Merged
paulromano merged 2 commits intoopenmc-dev:developfrom Jun 29, 2019
Merged
Option to pass fission q values to Chain, Operator, Model#1273paulromano merged 2 commits intoopenmc-dev:developfrom
paulromano merged 2 commits intoopenmc-dev:developfrom
Conversation
A dictionary of constant fission q values [eV] can be passed into the initialization of deplete.Chain, deplete.Operator, and model.Model objects. This can be used for direct comparisons with other codes with readily available constant Q-values. Tests have been added on the Chain and Operator side. The additional fiss_q_values passed into Model is forwarded directly on to the Operator call.
paulromano
requested changes
Jun 28, 2019
Contributor
paulromano
left a comment
paulromano
left a comment
There was a problem hiding this comment.
Nice and simple; thanks! On the naming of the optional argument, I guess I would prefer the slightly more verbose "fission_q_values" or "fission_q" (your pick).
Contributor
|
@drewejohnson looks like you missed naming changes in operator.py and nuclide.py |
drewejohnson
force-pushed
the
feat-op-qvalues
branch
from
c0b0af1 to
1e6f152
Compare
Contributor
Author
|
::facepalm:: sure enough. Thanks for catching that |
paulromano
approved these changes
Jun 28, 2019
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
Option to pass fission q values to Chain, Operator, Model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dictionary of constant fission q values [eV] can be passed into the initialization of deplete.Chain, deplete.Operator, and model.Model objects. This can be used for direct comparisons with other codes with readily available constant Q-values.
Tests have been added on the Chain and Operator side. The additional fiss_q_values passed into Model is forwarded directly on to the Operator call.