Use nbsphinx for rendering Jupyter notebooks in documentation#1690
Merged
pshriwise merged 2 commits intoopenmc-dev:developfrom Oct 20, 2020
Merged
Use nbsphinx for rendering Jupyter notebooks in documentation#1690pshriwise merged 2 commits intoopenmc-dev:developfrom
pshriwise merged 2 commits intoopenmc-dev:developfrom
Conversation
pshriwise
approved these changes
Oct 20, 2020
Contributor
pshriwise
left a comment
pshriwise
left a comment
There was a problem hiding this comment.
With those symbolic links to the notebooks added, this worked well for me! The notebooks look much better and it's nice to be rid of those additional .rst files. Thanks @paulromano!
Will merge today if there are no further comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building documentation is currently broken due to an issue with the nbconvert package that is used under the hood when converting Jupyter notebooks. This is addressed by using the nbsphinx which is much better than our existing notebook_sphinxext.py that is bundled in our repository.