Always set html_theme in readthedocs configuration#2667
Merged
shimwell merged 1 commit intoopenmc-dev:developfrom Aug 25, 2023
Merged
Always set html_theme in readthedocs configuration#2667shimwell merged 1 commit intoopenmc-dev:developfrom
shimwell merged 1 commit intoopenmc-dev:developfrom
Conversation
shimwell
approved these changes
Aug 25, 2023
Member
shimwell
left a comment
shimwell
left a comment
There was a problem hiding this comment.
Thanks for fixing this Paul, I've read the internal change description on the linked issue, I see that this is now passing the test for building the RTD and the changes make sense. As this is a small change let us get this merged in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Looks like our CI is currently failing on all PRs due to a readthedocs build failure, which in turn is due to an internal change in RTD. This PR should fix this by always setting
html_theme.Checklist
I have run clang-format on any C++ source files (if applicable)I have made corresponding changes to the documentation (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)