-
Notifications
You must be signed in to change notification settings - Fork 594
Extend level scattering to support incident photons #3675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
paulromano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GuySten Thanks for starting with a small PR to get us toward support for photonuclear physics. This PR just needs some documentation but otherwise it looks good to me.
| double LevelInelastic::sample(double E, uint64_t* seed) const | ||
| { | ||
| return mass_ratio_ * (E - threshold_); | ||
| return a_ * (E - b_ - c_ * (E * E)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This equation should be documented somewhere in our theory/methodology guide (probably docs/source/methods/photon_physics.rst) since the functional form is different than the neutron-nucleus case. You would need to either cite a reference that has this equation or provide a derivation from first principles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added documentation in docs/source/methods/photon_physics.rst.
include/openmc/distribution_energy.h
Outdated
| double a_; | ||
| double b_; | ||
| double c_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to have comments on these data members so someone looking at the class declaration knows what they are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've documented these data members.
Description
This PR extend Level Scattering to support incident photons.
This is a small step in implementing photonuclear physics.
Checklist