Add setting to optionally disable atomic relaxation#3855
Merged
paulromano merged 5 commits intoopenmc-dev:developfrom Mar 10, 2026
Merged
Add setting to optionally disable atomic relaxation#3855paulromano merged 5 commits intoopenmc-dev:developfrom
paulromano merged 5 commits intoopenmc-dev:developfrom
Conversation
paulromano
requested changes
Mar 6, 2026
Contributor
paulromano
left a comment
There was a problem hiding this comment.
Thanks @amandalund! Can you add a simple regression test to cover this case? Other than that, one comment on the documentation below:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a setting that allows users to optionally disable atomic relaxation in photon transport simulations. Atomic relaxation models the cascade of X-ray fluorescence photons and Auger electrons emitted when an inner-shell vacancy is filled. This option will be useful for performance benchmarking, and disabling relaxation may improve performance in simulations where detailed modeling of the secondary particle cascade is not needed.
Checklist