Skip to content

Add setting to optionally disable atomic relaxation#3855

Merged
paulromano merged 5 commits intoopenmc-dev:developfrom
amandalund:toggle-atomic-relaxation
Mar 10, 2026
Merged

Add setting to optionally disable atomic relaxation#3855
paulromano merged 5 commits intoopenmc-dev:developfrom
amandalund:toggle-atomic-relaxation

Conversation

@amandalund
Copy link
Contributor

@amandalund amandalund commented Mar 5, 2026

Description

This adds a setting that allows users to optionally disable atomic relaxation in photon transport simulations. Atomic relaxation models the cascade of X-ray fluorescence photons and Auger electrons emitted when an inner-shell vacancy is filled. This option will be useful for performance benchmarking, and disabling relaxation may improve performance in simulations where detailed modeling of the secondary particle cascade is not needed.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 18) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amandalund! Can you add a simple regression test to cover this case? Other than that, one comment on the documentation below:

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@paulromano paulromano enabled auto-merge (squash) March 10, 2026 03:15
@paulromano paulromano merged commit 1dc4aa9 into openmc-dev:develop Mar 10, 2026
16 checks passed
@amandalund amandalund deleted the toggle-atomic-relaxation branch March 10, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants