Skip to content

Improve review skill instructions for determining PR context#3875

Merged
jtramm merged 1 commit intoopenmc-dev:developfrom
paulromano:improve-branch-instructions
Mar 12, 2026
Merged

Improve review skill instructions for determining PR context#3875
jtramm merged 1 commit intoopenmc-dev:developfrom
paulromano:improve-branch-instructions

Conversation

@paulromano
Copy link
Copy Markdown
Contributor

Description

This PR addresses two related issues with the reviewing-openmc-code skill:

  1. There was no specific instruction to actually read the PR description, which may provide important context about the PR. The first step now is to view the PR (using the gh CLI preferentially) to read it.
  2. I was finding when running Claude Code within VS code that it kept comparing against the master branch even though the skill already says to compare against develop. When I asked CC why it did this, it said "the VSCode extension injects a Main branch (you will usually use this for PRs): master hint into every conversation". The updated instructions should avoid this.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 18) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@paulromano paulromano requested a review from jtramm March 12, 2026 18:17
Copy link
Copy Markdown
Contributor

@jtramm jtramm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jtramm jtramm merged commit 27522fe into openmc-dev:develop Mar 12, 2026
6 checks passed
@paulromano paulromano deleted the improve-branch-instructions branch March 13, 2026 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants