Improve review skill instructions for determining PR context#3875
Merged
jtramm merged 1 commit intoopenmc-dev:developfrom Mar 12, 2026
Merged
Improve review skill instructions for determining PR context#3875jtramm merged 1 commit intoopenmc-dev:developfrom
jtramm merged 1 commit intoopenmc-dev:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two related issues with the
reviewing-openmc-codeskill:ghCLI preferentially) to read it.masterbranch even though the skill already says to compare against develop. When I asked CC why it did this, it said "the VSCode extension injects aMain branch (you will usually use this for PRs): masterhint into every conversation". The updated instructions should avoid this.Checklist
I have run clang-format (version 18) on any C++ source files (if applicable)I have followed the style guidelines for Python source files (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)