Fix constructors with configuration#133
Merged
ironfede merged 1 commit intoopenmcdf:masterfrom Aug 3, 2024
Merged
Conversation
Contributor
MichelZ
commented
May 31, 2024
MichelZ
commented
- There are issues with certain constructors that not all configuration options are set properly. This is now consolidated to one function
- Constructors also refer to each other when possible to not duplicate too much code
Collaborator
|
Thank you @MichelZ for improvements |
This was referenced Aug 4, 2025
This was referenced Sep 4, 2025
This was referenced Apr 23, 2026
This was referenced Apr 23, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.