Skip to content

When saving an OLEProperties container of type 'AppSpecific' which ha…#137

Merged
ironfede merged 2 commits intoopenmcdf:masterfrom
Numpsy:users/rw/app_specific_property_names
Sep 15, 2024
Merged

When saving an OLEProperties container of type 'AppSpecific' which ha…#137
ironfede merged 2 commits intoopenmcdf:masterfrom
Numpsy:users/rw/app_specific_property_names

Conversation

@Numpsy
Copy link
Copy Markdown
Contributor

@Numpsy Numpsy commented Jun 16, 2024

…s custom property names present, write a dictinoary property to the output stream

refs #134

As it stands now, if you read a property set other than SummaryInformation/DocumentSummaryInformation, and then save that back to the file, and that set contains a DictionaryProperty, then said dictionary will be lost.

So - try always writing it for AppSpecific sets (we don't want to write such a property for Summry/DocSummary).

@Numpsy Numpsy force-pushed the users/rw/app_specific_property_names branch from 0c1d353 to 3d750d1 Compare September 3, 2024 23:32
…s custom property names present, write a dictinoary property to the output stream
@Numpsy Numpsy force-pushed the users/rw/app_specific_property_names branch from 3d750d1 to 69f2f44 Compare September 11, 2024 01:12
@Numpsy
Copy link
Copy Markdown
Contributor Author

Numpsy commented Sep 11, 2024

@ironfede @farfilli Any thoughts or comments on how useful this is or if it should be completed now? (I can see about adding a unit test if it's useful)

@farfilli
Copy link
Copy Markdown

It's sure useful!

@Numpsy Numpsy force-pushed the users/rw/app_specific_property_names branch from 40abaed to 62036c1 Compare September 14, 2024 09:49
@Numpsy
Copy link
Copy Markdown
Contributor Author

Numpsy commented Sep 14, 2024

Test added

@Numpsy Numpsy marked this pull request as ready for review September 14, 2024 09:51
@ironfede
Copy link
Copy Markdown
Collaborator

Many Thanks @Numpsy ! Merging now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants