Skip to content

feat: add aliases for smartrequeue functions#229

Merged
Diaphteiros merged 1 commit intomainfrom
smartrequeue
Apr 29, 2026
Merged

feat: add aliases for smartrequeue functions#229
Diaphteiros merged 1 commit intomainfrom
smartrequeue

Conversation

@Diaphteiros
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This is a convenience feature for developers. The smart requeue functionality was originally implemented with requeuing processing resources immediately and 'stable' resources with an increasing backoff. However, we have multiple controllers which don't use the library this way, making the naming of the functions IsProgressing and IsStable really unintuitive, sometimes even counter-intuitive. This PR adds aliases for both functions to address this problem.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Release note:

The smart requeue library now allows to use `RequeueWithBackoff` as an alias for `IsStable` and `RequeueWithReset` as an alias for `IsProgressing`. This is meant to cause less confusion when using the library in a different context than it was originally built for.

@Diaphteiros Diaphteiros merged commit 916f6b9 into main Apr 29, 2026
8 checks passed
@Diaphteiros Diaphteiros deleted the smartrequeue branch April 29, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants