feat(errors): invalid user input error handling#236
Merged
Conversation
Introduces ErrInvalidUserInput and IgnoreInvalidUserInput(error) to ignore user input errors at the end of reconciliation. This allows you to handle errors properly and skip unnecessary requeues. On-behalf-of: @SAP christopher.junk@sap.com Signed-off-by: Christopher Junk <christopher.junk@sap.com>
christophrj
force-pushed
the
feat/user-input-errors
branch
from
0affa04 to
0a7e66d
Compare
Diaphteiros
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On-behalf-of: @SAP christopher.junk@sap.com
What this PR does / why we need it:
This PR introduces
ErrInvalidUserInputandIgnoreInvalidUserInput(error)for consistent user input error handling in service providers.ErrInvalidUserInputis used to create errors that can be ignored at the end of reconciliation. This allows you to handle errors properly and skip unnecessary requeues.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Based on the discussion of openmcp-project/service-provider-flux#46.
I simplified the initial sp-flux implementation to just a predefined error with a helper for reuse in service providers and potentially other controllers.
Release note: