Workspace Cypress tests (Creation/Deletion) #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors workspace creation and deletion logic by extracting it into reusable custom hooks (useCreateWorkspace and useDeleteWorkspace), improving code modularity and testability.
- Extracts workspace creation logic from
CreateWorkspaceDialogContainerintouseCreateWorkspacehook - Creates new
useDeleteWorkspacehook for workspace deletion - Adds comprehensive unit tests for both hooks
- Updates components to use the new hooks with dependency injection for better testability
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/hooks/useDeleteWorkspace.tsx |
New hook encapsulating workspace deletion logic with toast notifications and error handling |
src/hooks/useDeleteWorkspace.spec.tsx |
Unit tests for the delete workspace hook |
src/hooks/useCreateWorkspace.tsx |
New hook encapsulating workspace creation logic with toast notifications and error handling |
src/hooks/useCreateWorkspace.spec.tsx |
Unit tests for the create workspace hook |
src/components/Dialogs/CreateWorkspaceDialogContainer.tsx |
Refactored to use the new useCreateWorkspace hook with dependency injection support |
src/components/Dialogs/CreateWorkspaceDialogContainer.cy.tsx |
Cypress component tests for the dialog container |
src/components/ControlPlanes/List/ControlPlaneListWorkspaceGridTile.tsx |
Updated to use the new useDeleteWorkspace hook with dependency injection support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andreaskienle
requested changes
Oct 29, 2025
There was a problem hiding this comment.
Thanks for the tests! Some remarks below.
Also: Can we rename the hooks (and their tests) from .tsx to .ts? I know, I had this in the template PR but I changed it with the follow-up PR. That's on me 😅
src/components/ControlPlanes/List/ControlPlaneListWorkspaceGridTile.tsx
Outdated
Show resolved
Hide resolved
andreaskienle
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Tests for Workspace creation + Deletion hook change.
Workspace deletion is using generic component, so tests are already done in - DeleteConfirmationDialog.cy.tsx
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: