fix: update DeletionEvent to retrieve MCPUsage before updating deleti… #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request improves deletion event handling for MCPUsage resources by refactoring the logic to retrieve existing objects before updating them, and bumps the project version from v0.0.13-dev to v0.0.14.
- Refactored DeletionEvent method to use Get-then-Update pattern instead of creating and patching new objects
- Improved error handling for MCPUsage resource retrieval
- Updated project version to v0.0.14
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/usage/tracking.go | Refactored DeletionEvent method to fetch existing MCPUsage before updating deletion timestamp |
| VERSION | Bumped version from v0.0.13-dev to v0.0.14 |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
robertgraeff
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the project version and refines how deletion events are tracked for MCPUsage resources. The main focus is on improving the logic for updating MCPUsage objects when a deletion event occurs.
Version update:
v0.0.13-devtov0.0.14in theVERSIONfile.MCPUsage deletion event handling:
DeletionEventmethod ininternal/usage/tracking.goto first fetch the existingMCPUsageobject before updating its deletion timestamp, rather than patching a newly constructed object. This ensures that updates are made only to existing resources and handles errors more robustly.