[ISSUE33]Add extension Attributes & Interface #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyue2008
reviewed
Feb 25, 2019
| int getShort(String key); | ||
| short getShort(String key); | ||
|
|
||
| /** |
There was a problem hiding this comment.
For getters with a numeric return type, my suggestion is :
- Return the wrapper class instead a primitive data type.
- Return a null value if the provided key is not found.
Short getShort(String key);
Member
Author
There was a problem hiding this comment.
It seems that we should define so many interface or method?
There was a problem hiding this comment.
No need， just repliace the method "short getShort(String key);" to "Short getShort(String key);"
| * @version OMS 1.0.0 | ||
| * @since OMS 1.0.0 | ||
| */ | ||
| public interface ExtensionClient { |
There was a problem hiding this comment.
Is there any way to get a instance for the new added interface io.openmessaging.extension.ExtensionClient.
There should be a getExcensionCleint method in the MessagingAccessPoint or other interfaces.
Member
Author
There was a problem hiding this comment.
yep, I also think it should be a method which can be found in Producer or Consumer. what's your opinion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) Add extension attributes & interface.
(2) Keep consistent with specification.