[ISSUE #51]Consumer should support bulk subscription queue and poll message by offset #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue and poll message by offset .
…onId,offset) in the batchReceive method.
…d batch receive method.
duhenglucky
reviewed
May 7, 2019
| * @throws OMSTimeOutException when the given timeout elapses before the send operation completes. | ||
| * @throws OMSRuntimeException when the {@code Producer} fails to send the message due to some internal error. | ||
| */ | ||
| Message receive(String queueName,@Optional int partitionId, long receiptId, long timeout); |
Member
There was a problem hiding this comment.
it would be nice if you can put this anotation above this method.
Contributor
Author
There was a problem hiding this comment.
Okay,I have already finished it.
| * @throws OMSTimeOutException when the given timeout elapses before the send operation completes. | ||
| * @throws OMSRuntimeException when the {@code Producer} fails to send the message due to some internal error. | ||
| */ | ||
| List<Message> batchReceive(String queueName,@Optional int partitionId, long receiptId, long timeout); |
Contributor
Author
There was a problem hiding this comment.
Okay,I have already finished it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
（1）Consumer should support bulk subscription queue and poll message by offset.
Brief changelog
（1）Consumer should support bulk subscription queue and poll message by offset.
Verifying this change
（1）Consumer should support bulk subscription queue and poll message by offset.
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.
Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
If this contribution is large, please file an Apache Individual Contributor License Agreement.