Merged
Conversation
tothandras
requested changes
Aug 16, 2023
Contributor
tothandras
left a comment
tothandras
left a comment
There was a problem hiding this comment.
Should we make it optional? Seems like the telemetry address is required.
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Co-authored-by: András Tóth <4157749+tothandras@users.noreply.github.com> Signed-off-by: Márk Sági-Kazár <sagikazarmark@users.noreply.github.com>
Contributor
Author
|
Telemetry address was required even before this change, but has a default value. We can think about making it optional later, but it doesn't cost anything. |
Contributor
|
I see, I thought it was a push address. |
tothandras
approved these changes
Aug 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds basic otel trace support for incoming requests. Integration for downstream requests (kafka, clickhouse) will be added in subsequent PRs.
Notes for reviewer