fix: customeroverride overload #2372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gathering invoice handling needs a lock to prevent parallel executions of the gathering invoice creation. Previously we were using the billing_customeroverride table for this however that results in a lot of empty rows there, which makes it hard to understand the user intent behind the row. This patch modifies this behavior by creating a dedicated lock table that we can use for gathering invoice coordination if needed.
turip
added
release-note/misc
chrisgacsal
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Gathering invoice handling (pending line creation) needs a lock to prevent parallel executions of the gathering invoice creation.
Previously, we were using the billing_customeroverride table for this; however, that results in many empty rows there, making it hard to understand the user intent behind the row.
This patch modifies this behavior by creating a dedicated lock table that we can use for gathering invoice coordination if needed.