refactor(api): apply type conversion naming pattern#4135
Merged
tothandras merged 2 commits intomainfrom Apr 13, 2026
Merged
Conversation
tothandras
added
the
release-note/ignore
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (46)
✅ Files skipped from review due to trivial changes (14)
🚧 Files skipped from review as they are similar to previous changes (24)
📝 WalkthroughWalkthroughThis PR adds a skill spec for Go type-conversion naming and applies a large-scale rename: conversion helpers across api/v3/handlers/* are changed from generic Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsTimed out fetching pipeline failures after 30000ms Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
api/v3/handlers/subscriptions/convert.go (1)
17-35: Optional readability tweak: avoidsubscriptionname shadowing.Totally works as-is, but renaming the function param (e.g.
sub) would make this a bit easier to read.Suggested refactor
-func ToAPIBillingSubscription(subscription subscription.Subscription) api.BillingSubscription { +func ToAPIBillingSubscription(sub subscription.Subscription) api.BillingSubscription { subscriptionAPI := api.BillingSubscription{ - Id: subscription.ID, - CustomerId: subscription.CustomerId, - BillingAnchor: subscription.BillingAnchor, - Status: api.BillingSubscriptionStatus(subscription.GetStatusAt(clock.Now())), - Labels: labels.FromMetadataAnnotations(subscription.Metadata, subscription.Annotations), - CreatedAt: &subscription.CreatedAt, - UpdatedAt: &subscription.UpdatedAt, - DeletedAt: subscription.DeletedAt, + Id: sub.ID, + CustomerId: sub.CustomerId, + BillingAnchor: sub.BillingAnchor, + Status: api.BillingSubscriptionStatus(sub.GetStatusAt(clock.Now())), + Labels: labels.FromMetadataAnnotations(sub.Metadata, sub.Annotations), + CreatedAt: &sub.CreatedAt, + UpdatedAt: &sub.UpdatedAt, + DeletedAt: sub.DeletedAt, } // Only set if the subscription is created from a plan - if subscription.PlanRef != nil { - subscriptionAPI.PlanId = &subscription.PlanRef.Id + if sub.PlanRef != nil { + subscriptionAPI.PlanId = &sub.PlanRef.Id }As per coding guidelines, “In general when reviewing the Golang code make readability and maintainability a priority, even potentially suggest restructuring the code to improve them.”
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@api/v3/handlers/subscriptions/convert.go` around lines 17 - 35, The parameter name subscription in ToAPIBillingSubscription shadows the package/type name and hurts readability; rename the function parameter (for example change subscription Subscription to sub subscription.Subscription) and update all references inside the function (e.g., subscriptionAPI fields, the PlanRef check, subscription.GetStatusAt(clock.Now()), subscription.Metadata, subscription.Annotations, subscription.CreatedAt/UpdatedAt/DeletedAt, and subscription.PlanRef.Id) so the code uses the new param name (sub) and preserves existing behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.agents/skills/go-types-conversion/SKILL.md:
- Around line 91-94: Rename MapChargeFlatFeeFromDB to FromDBChargeFlatFee and
update all callers to use the new name; change the function currently named With
"FromAPI…" that actually converts domain -> API to ToAPIPlan (invert the
direction label) and remove its error return if it never fails; finally, in
SKILL.md fix the blockquote spacing by removing blank lines between consecutive
blockquote lines so markdownlint MD028 no longer fires.
---
Nitpick comments:
In `@api/v3/handlers/subscriptions/convert.go`:
- Around line 17-35: The parameter name subscription in ToAPIBillingSubscription
shadows the package/type name and hurts readability; rename the function
parameter (for example change subscription Subscription to sub
subscription.Subscription) and update all references inside the function (e.g.,
subscriptionAPI fields, the PlanRef check,
subscription.GetStatusAt(clock.Now()), subscription.Metadata,
subscription.Annotations, subscription.CreatedAt/UpdatedAt/DeletedAt, and
subscription.PlanRef.Id) so the code uses the new param name (sub) and preserves
existing behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b786f7af-731d-4048-84f8-3ebadf33a68f
📒 Files selected for processing (47)
.agents/skills/go-types-conversion/SKILL.mdapi/v3/handlers/apps/convert.gen.goapi/v3/handlers/apps/convert.goapi/v3/handlers/apps/get_app.goapi/v3/handlers/apps/list_app.goapi/v3/handlers/billingprofiles/convert.gen.goapi/v3/handlers/billingprofiles/convert.goapi/v3/handlers/billingprofiles/create.goapi/v3/handlers/billingprofiles/get.goapi/v3/handlers/billingprofiles/list.goapi/v3/handlers/billingprofiles/update.goapi/v3/handlers/currencies/convert.goapi/v3/handlers/currencies/create.goapi/v3/handlers/currencies/create_cost_basis.goapi/v3/handlers/currencies/get_cost_bases.goapi/v3/handlers/currencies/list.goapi/v3/handlers/customers/billing/convert.gen.goapi/v3/handlers/customers/billing/convert.goapi/v3/handlers/customers/billing/create_customer_stripe_checkout_session.goapi/v3/handlers/customers/billing/create_customer_stripe_portal_session.goapi/v3/handlers/customers/convert.gen.goapi/v3/handlers/customers/convert.goapi/v3/handlers/customers/create.goapi/v3/handlers/customers/get.goapi/v3/handlers/customers/list.goapi/v3/handlers/customers/upsert.goapi/v3/handlers/featurecost/convert.goapi/v3/handlers/featurecost/query.goapi/v3/handlers/meters/convert.gen.goapi/v3/handlers/meters/convert.goapi/v3/handlers/meters/create.goapi/v3/handlers/meters/get.goapi/v3/handlers/meters/list.goapi/v3/handlers/meters/query.goapi/v3/handlers/subscriptions/cancel.goapi/v3/handlers/subscriptions/change.goapi/v3/handlers/subscriptions/convert.goapi/v3/handlers/subscriptions/create.goapi/v3/handlers/subscriptions/get.goapi/v3/handlers/subscriptions/list.goapi/v3/handlers/subscriptions/unschedule_cancelation.goapi/v3/handlers/taxcodes/convert.gen.goapi/v3/handlers/taxcodes/convert.goapi/v3/handlers/taxcodes/create.goapi/v3/handlers/taxcodes/get.goapi/v3/handlers/taxcodes/list.goapi/v3/handlers/taxcodes/update.go
tothandras
force-pushed
the
chore/types-conversion-skill
branch
from
57de92e to
97ef73c
Compare
chrisgacsal
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Documentation
Refactor