Skip to content
This repository was archived by the owner on Jul 5, 2025. It is now read-only.

Conversation

@aaronschweig
Copy link
Member

@aaronschweig aaronschweig commented Apr 2, 2025

This PR adds a readonly mode to the lifecycle controller that skips all eventual status update to work with initializing workspaces in kcp.

@aaronschweig aaronschweig requested a review from a team as a code owner April 2, 2025 09:37
@nexus49
Copy link
Member

nexus49 commented Apr 2, 2025

It would be great to add a check so that WithReadOnly and WithConditionManagement/WithSpreadReconcile cannot be used together.

@github-actions github-actions bot added the fix label Apr 2, 2025
@aaronschweig
Copy link
Member Author

It would be great to add a check so that WithReadOnly and WithConditionManagement/WithSpreadReconcile cannot be used together.

Done I implemented it in here:

if (l.manageConditions || l.spreadReconciles) && l.readOnly {
return nil, fmt.Errorf("cannot use conditions or spread reconciles in read-only mode")
}

@aaronschweig aaronschweig merged commit 63401b4 into main Apr 2, 2025
9 checks passed
@aaronschweig aaronschweig deleted the feat/lifecycle-readonly-mode branch April 2, 2025 12:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants