Accessibility#135
Merged
Merged
Conversation
Signed-off-by: Sobyt483 <andrianingomel@gmail.com>
Signed-off-by: Sobyt483 <andrianingomel@gmail.com>
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughAccessibility and interaction updates: adds accessibleName attributes across dashboard and table components, enables Enter-key activation on visited-service cards, auto-focuses the Add Card button after entering edit mode, and tracks clipboard copy success with a new signal in ValueCell. ChangesAccessibility and interaction enhancements
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6 tasks
Signed-off-by: Sobyt483 <andrianingomel@gmail.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@projects/ngx/cards/visited-service-card/visited-service-card.component.html`:
- Around line 3-6: The element is given button semantics but only activates on
Enter; add handling for the Space key so keyboard users get expected button
behavior by invoking the same action and preventing default scrolling. Update
the template for VisitedServiceCardComponent to handle keydown.space the same as
keydown.enter (call cardClick.emit(path())) and call $event.preventDefault() to
stop page scroll; alternatively implement a component method (e.g.,
onCardKeydown(event)) that checks event.code or event.key for ' ' / 'Space' and
'Enter', prevents default for Space, and emits via cardClick.emit(path()) so
both keys activate the control.
In `@projects/ngx/declarative-ui/value-cell/value-cell.component.ts`:
- Around line 105-110: The copyValue clipboard call only handles the success
path; update the navigator.clipboard.writeText(this.value() || '') call inside
copyValue to handle rejections (e.g., add a .catch or use try/await with
try/catch) so copySuccess is reset on failure and errors are surfaced (set
this.copySuccess.set(false) in the failure branch and optionally log the error).
Locate the clipboard invocation in copyValue and ensure both success and failure
paths explicitly update the copySuccess signal.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b00e6410-1673-4a52-9890-be7ecb8a371b
📒 Files selected for processing (9)
projects/ngx/cards/visited-service-card/visited-service-card.component.htmlprojects/ngx/declarative-ui/dashboard/card/dashboard-card.component.htmlprojects/ngx/declarative-ui/dashboard/dashboard/dashboard.component.htmlprojects/ngx/declarative-ui/dashboard/dashboard/dashboard.component.tsprojects/ngx/declarative-ui/dashboard/section/dashboard-section.component.htmlprojects/ngx/declarative-ui/table-card/declarative-table-card.component.htmlprojects/ngx/declarative-ui/table-card/declarative-table-card.component.tsprojects/ngx/declarative-ui/value-cell/value-cell.component.htmlprojects/ngx/declarative-ui/value-cell/value-cell.component.ts
gkrajniak
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes / Accessibility