Revert "Fix missing points (#919)"#923
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d50d59cd80
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (geoJson->hasOnlyPoints) { | ||
| options.maxZoom = options.minZoom; |
There was a problem hiding this comment.
Reverting this condition to if (geoJson->hasOnlyPoints) makes every point-only source collapse to a single zoom level by setting options.maxZoom = options.minZoom, and minZoom defaults to 0 when the style omits it (Tiled2dMapVectorLayerParserHelper.cpp only sets options.minZoom when minzoom is present). In the common case of GeoJSON sources without explicit minzoom, this forces all symbols through z0 geometry and reintroduces the missing-point behavior (points get dropped at runtime due to coarse matching/collision ownership) that #919 fixed.
Useful? React with 👍 / 👎.
|
Note: baseline benchmark runs on main branch are failing, this is effectively what we fix in this PR. |
2 participants
Revert "Fix missing Points (#919)" and the subsequent (icomplete) fix up for tests.
Fix for the problem addressed by #919 is to increase the "extent".