ci: skip test-reporter on fork PRs; explain in annotation#240
Merged
Conversation
Mirrors moxygen PR #164. dorny/test-reporter writes a GitHub Check Run, which requires 'checks: write' on GITHUB_TOKEN. Fork-PR tokens are read-only by GitHub security policy regardless of workflow permissions — so the step always fails on cross-repo PRs. Guard the step on same-repo pull_request events. Add a sibling notice step that explains the skip on fork PRs. test-log output remains authoritative for pass/fail.
gmarzot
requested review from
Oxyd,
TimEvens,
afrind,
akash-a-n,
michalhosna,
mondain,
peterchave and
suhasHere
as code owners
peterchave
approved these changes
Apr 22, 2026
peterchave
left a comment
peterchave
left a comment
There was a problem hiding this comment.
@peterchave reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on afrind, akash-a-n, michalhosna, mondain, Oxyd, suhasHere, and TimEvens).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirror of moxygen #164. `dorny/test-reporter` requires `checks: write` on `GITHUB_TOKEN`; fork-PR tokens are read-only regardless of workflow perms. Guard the reporter step to skip on cross-repo PRs; add a notice annotation explaining the skip.
Effect
Test plan
This change is