Skip to content

stats: track additional QUIC counter events#283

Merged
afrind merged 1 commit intomainfrom
stats/quic-counter-events
May 6, 2026
Merged

stats: track additional QUIC counter events#283
afrind merged 1 commit intomainfrom
stats/quic-counter-events

Conversation

@afrind
Copy link
Copy Markdown
Contributor

@afrind afrind commented May 4, 2026

Wire onPacketProcessed, onPTO, onPacketSpuriousLoss, onPersistentCongestion, onConnectionWritableBytesLimited, onConnectionRateLimited, onPacerTimerLagged, and onUDPSocketWriteError into the stats data structures instead of no-opping. Split quicPacketRetransmissions into timerLosses/spuriousLosses in pico path.


This change is Reviewable

@afrind afrind force-pushed the stats/quic-counter-events branch 3 times, most recently from 9c4989b to 16f1935 Compare May 4, 2026 18:02
Copy link
Copy Markdown
Contributor

@gmarzot gmarzot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmarzot reviewed 4 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on akash-a-n, michalhosna, mondain, Oxyd, peterchave, suhasHere, and TimEvens).

Copy link
Copy Markdown
Contributor Author

@afrind afrind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afrind made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on akash-a-n, michalhosna, mondain, Oxyd, peterchave, suhasHere, and TimEvens).


src/stats/QuicStatsCollector.cpp line 116 at r1 (raw file):

      ++data_->quicSocketWriteNobufs_;
    }
  }

Let's add quicSocketWriteOther_ or quicSocketWriteTotal_ to capture other errors

Wire onPacketProcessed, onPTO, onPacketSpuriousLoss, onPersistentCongestion,
onConnectionWritableBytesLimited, onConnectionRateLimited, onPacerTimerLagged,
and onUDPSocketWriteError into the stats data structures instead of no-opping.
Split quicPacketRetransmissions into timerLosses/spuriousLosses in pico path.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@afrind afrind force-pushed the stats/quic-counter-events branch from 16f1935 to c83a33f Compare May 6, 2026 18:36
Copy link
Copy Markdown
Contributor Author

@afrind afrind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afrind resolved 1 discussion.
Reviewable status: 2 of 4 files reviewed, all discussions resolved (waiting on gmarzot, michalhosna, mondain, Oxyd, peterchave, suhasHere, and TimEvens).

@afrind afrind merged commit 3c4dc15 into main May 6, 2026
11 of 12 checks passed
@afrind afrind deleted the stats/quic-counter-events branch May 6, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants