OpenCV4 upgrade with CUDA #174
Conversation
Conflicts: cpp/OcvDnnDetection/plugin-files/descriptor/descriptor.json
There was a problem hiding this comment.
Reviewed 28 of 28 files at r1.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @brosenberg42)
cpp/DarknetDetection/Dockerfile, line 73 at r1 (raw file):
#################################################### FROM darknet_component as sample_executable
What's the motivation for adding this? Just to make manual testing easier before we land the CLI Runner update?
cpp/DarknetDetection/sample_darknet_detector.cpp, line 42 at r1 (raw file):
int main(int argc, char* argv[]) { if (argc == 2) {
Should we document this usage in the usage print out?
cpp/DlibFaceDetection/CMakeLists.txt, line 34 at r1 (raw file):
set(USE_AVX_INSTRUCTIONS ON) set(DLIB_USE_CUDA OFF)
I'm assuming it didn't use CUDA before. Was version 19.20 trying to build with CUDA by default?
cpp/OcvDnnDetection/sample_ocv_dnn_classifier.cpp, line 40 at r1 (raw file):
if (argc == 2) { std::string arg1 = argv[1]; if (arg1 == "gpu-info") {
Should we document this usage in the usage print out?
cpp/TesseractOCRTextDetection/Dockerfile, line 35 at r1 (raw file):
&& yum --enablerepo=remi install -y ImageMagick ImageMagick-c++ \ ImageMagick-c++-devel ImageMagick-devel ImageMagick-libs \ libgif libjpeg libpng libtiff zlib ghostscript \
What motivated you to remove this?
There was a problem hiding this comment.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @brosenberg42)
There was a problem hiding this comment.
Reviewable status: 26 of 34 files reviewed, 5 unresolved discussions (waiting on @brosenberg42 and @jrobble)
cpp/DarknetDetection/Dockerfile, line 73 at r1 (raw file):
Previously, jrobble (Jeff Robble) wrote…
What's the motivation for adding this? Just to make manual testing easier before we land the CLI Runner update?
It was added before CLI runner task was even given to us. I added so I could test on the GPU server.
cpp/DarknetDetection/sample_darknet_detector.cpp, line 42 at r1 (raw file):
Previously, jrobble (Jeff Robble) wrote…
Should we document this usage in the usage print out?
Done.
cpp/DlibFaceDetection/CMakeLists.txt, line 34 at r1 (raw file):
Previously, jrobble (Jeff Robble) wrote…
I'm assuming it didn't use CUDA before. Was version 19.20 trying to build with CUDA by default?
I get a build error without that line. I didn't think it was worth my time to figure how to get it running on gpu since no one uses it.
cpp/OcvDnnDetection/sample_ocv_dnn_classifier.cpp, line 40 at r1 (raw file):
Previously, jrobble (Jeff Robble) wrote…
Should we document this usage in the usage print out?
Done.
cpp/TesseractOCRTextDetection/Dockerfile, line 35 at r1 (raw file):
Previously, jrobble (Jeff Robble) wrote…
What motivated you to remove this?
It was never used. The build started failing because of yum-config-manager --setopt=skip_missing_names_on_install=False --save;
There was a problem hiding this comment.
Reviewed 8 of 8 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
cpp/DlibFaceDetection/CMakeLists.txt, line 34 at r1 (raw file):
Previously, brosenberg42 wrote…
I get a build error without that line. I didn't think it was worth my time to figure how to get it running on gpu since no one uses it.
Agreed.
Associated PRs:
Issues:
This change is