OpenCV4 upgrade with CUDA #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 20, 2020
jrobble
approved these changes
Dec 11, 2020
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
jrobble
requested changes
Dec 11, 2020
There was a problem hiding this comment.
Please update the version number in the C++ component SDK examples:
openmpf-cpp-component-sdk/detection/examples/AudioOnlyComponent/CMakeLists.txt:find_package(OpenCV 3.4.7 EXACT REQUIRED PATHS /opt/opencv-3.4.7 COMPONENTS opencv_core)
openmpf-cpp-component-sdk/detection/examples/AudioOnlyComponent/README.md:NOTE: To build and run this component, OpenCV 3.4.7
openmpf-cpp-component-sdk/detection/examples/AudioOnlyComponent/README.md:the root directory of your OpenCV 3.4.7 installation.
openmpf-cpp-component-sdk/detection/examples/GenericComponent/CMakeLists.txt:find_package(OpenCV 3.4.7 EXACT REQUIRED PATHS /opt/opencv-3.4.7 COMPONENTS opencv_core)
openmpf-cpp-component-sdk/detection/examples/GenericComponent/README.md:NOTE: To build and run this component, OpenCV 3.4.7
openmpf-cpp-component-sdk/detection/examples/GenericComponent/README.md:the root directory of your OpenCV 3.4.7 installation.
openmpf-cpp-component-sdk/detection/examples/HelloWorldComponent/README.md:NOTE: To build and run this component, OpenCV 3.4.7
openmpf-cpp-component-sdk/detection/examples/HelloWorldComponent/README.md:the root directory of your OpenCV 3.4.7 installation.
openmpf-cpp-component-sdk/detection/examples/HelloWorldComponent/CMakeLists.txt:find_package(OpenCV 3.4.7 EXACT REQUIRED PATHS /opt/opencv-3.4.7 COMPONENTS opencv_core)
openmpf-cpp-component-sdk/detection/examples/ImageTransformerComponent/CMakeLists.txt:find_package(OpenCV 3.4.7 EXACT REQUIRED PATHS /opt/opencv-3.4.7 COMPONENTS opencv_core opencv_highgui)
openmpf-cpp-component-sdk/detection/examples/ImageTransformerComponent/README.md:NOTE: To build and run this component, OpenCV 3.4.7
openmpf-cpp-component-sdk/detection/examples/ImageTransformerComponent/README.md:the root directory of your OpenCV 3.4.7 installation.
openmpf-cpp-component-sdk/detection/examples/VideoCaptureComponent/CMakeLists.txt:find_package(OpenCV 3.4.7 EXACT REQUIRED PATHS /opt/opencv-3.4.7 COMPONENTS opencv_core opencv_highgui)
openmpf-cpp-component-sdk/detection/examples/VideoCaptureComponent/README.md:NOTE: To build and run this component, OpenCV 3.4.7 and
openmpf-cpp-component-sdk/detection/examples/VideoCaptureComponent/README.md:the root directory of your OpenCV 3.4.7 installation
Reviewable status:
jrobble
approved these changes
Dec 16, 2020
There was a problem hiding this comment.
Reviewed 11 of 11 files at r2.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated PRs:
Issues:
This change is