Skip to content

Conversation

@brosenberg42
Copy link
Member

@brosenberg42 brosenberg42 commented May 28, 2024

Copy link
Member

@jrobble jrobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @brosenberg42)


openmpf_build/scripts/copy_libs.sh line 10 at r1 (raw file):

# 52.227-14, Alt. IV (DEC 2007).                                            #
#                                                                           #
# Copyright 2023 The MITRE Corporation. All Rights Reserved.                #

Update this copyright and the one below to 2024. Please make sure the others are updated as well after merging with develop.


openmpf_build/scripts/copy_libs.sh line 59 at r1 (raw file):

            # The library we are copying might also have dependencies, so we will need to run
            # ldd again once the library is copied in.
            NEED_TO_CHECK_MISSING_LIBS=true

If the library we're looking for is not in $lib_copy_src_dir then the cp will fail, right? That would result in the build failing?

Just making sure we handle that scenario.

Copy link
Member Author

@brosenberg42 brosenberg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @jrobble)


openmpf_build/scripts/copy_libs.sh line 10 at r1 (raw file):

Previously, jrobble (Jeff Robble) wrote…

Update this copyright and the one below to 2024. Please make sure the others are updated as well after merging with develop.

Done.


openmpf_build/scripts/copy_libs.sh line 59 at r1 (raw file):

Previously, jrobble (Jeff Robble) wrote…

If the library we're looking for is not in $lib_copy_src_dir then the cp will fail, right? That would result in the build failing?

Just making sure we handle that scenario.

Yes to both

Copy link
Member

@jrobble jrobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @brosenberg42)

@brosenberg42 brosenberg42 merged commit e258692 into develop Jun 3, 2024
@brosenberg42 brosenberg42 deleted the feat/copy-less-libs branch June 3, 2024 17:55
clnowacki pushed a commit that referenced this pull request Jul 28, 2025
(cherry picked from commit e258692)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants