-
Notifications
You must be signed in to change notification settings - Fork 4
Feat/copy less libs #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/copy less libs #217
Conversation
jrobble
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @brosenberg42)
openmpf_build/scripts/copy_libs.sh line 10 at r1 (raw file):
# 52.227-14, Alt. IV (DEC 2007). # # # # Copyright 2023 The MITRE Corporation. All Rights Reserved. #
Update this copyright and the one below to 2024. Please make sure the others are updated as well after merging with develop.
openmpf_build/scripts/copy_libs.sh line 59 at r1 (raw file):
# The library we are copying might also have dependencies, so we will need to run # ldd again once the library is copied in. NEED_TO_CHECK_MISSING_LIBS=true
If the library we're looking for is not in $lib_copy_src_dir then the cp will fail, right? That would result in the build failing?
Just making sure we handle that scenario.
brosenberg42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @jrobble)
openmpf_build/scripts/copy_libs.sh line 10 at r1 (raw file):
Previously, jrobble (Jeff Robble) wrote…
Update this copyright and the one below to 2024. Please make sure the others are updated as well after merging with develop.
Done.
openmpf_build/scripts/copy_libs.sh line 59 at r1 (raw file):
Previously, jrobble (Jeff Robble) wrote…
If the library we're looking for is not in
$lib_copy_src_dirthen thecpwill fail, right? That would result in the build failing?Just making sure we handle that scenario.
Yes to both
jrobble
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @brosenberg42)
(cherry picked from commit e258692)
Issues:
Related PRs:
This change is