Skip to content

Conversation

brosenberg42
Copy link
Member

@brosenberg42 brosenberg42 commented Dec 8, 2023

Copy link
Member

@jrobble jrobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @brosenberg42)

a discussion (no related file):
We should explain how to access the ActiveMQ management page at http://<ip-addr>:8080/actuator/hawtio, and through the navbar.

I think it belongs in the Admin Guide. I say Admin Guide and not User Guide since I think we should limit access to admin users only. You can start and stop Camel routes, among other things, which can really mess things up.


a discussion (no related file):
The custom system tests README has these lines that needs to be updated:

  • Then, start ActiveMQ, MySQL, Redis, and NodeManager.

Start ActiveMQ, MySQL, Redis, and NodeManager.

Also, the file still mentions mpf start --xtc. --xtc is now --xwfm.


a discussion (no related file):
Update these lines in the OIDC Connect Guide:

- Login settings:
    - Set "Valid redirect URIs" to
      `http://localhost:8080/workflow-manager/login/oauth2/code/provider`
    - Set "Valid post logout redirect URIs" to `http://localhost:8080/workflow-manager`
curl -H "Authorization: Bearer <access-token>" http://localhost:8080/workflow-manager/rest/actions

a discussion (no related file):
Please update REST-API.html:

            <td><span class='small-heading'>Base Path:</span></td>
            <td><span class='subheading-text'>/workflow-manager</span></td>


docs/docs/Development-Environment-Guide.md line 243 at r1 (raw file):

After startup, the Workflow Manager will be available at
<http://localhost:8080/workflow-manager>.

Update this URL.


docs/docs/User-Guide.md line 16 at r1 (raw file):

## Accessing the Web UI

On the server hosting the Open Media Processing Framework, the Web UI is accessible at http://localhost:8080/workflow-manager. To access it from other machines, substitute the hostname or IP address of the master node server in place of "localhost".

Update this URL.

Copy link
Member Author

@brosenberg42 brosenberg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 13 files reviewed, 6 unresolved discussions (waiting on @brosenberg42 and @jrobble)

a discussion (no related file):

Previously, jrobble (Jeff Robble) wrote…

We should explain how to access the ActiveMQ management page at http://<ip-addr>:8080/actuator/hawtio, and through the navbar.

I think it belongs in the Admin Guide. I say Admin Guide and not User Guide since I think we should limit access to admin users only. You can start and stop Camel routes, among other things, which can really mess things up.

Done.


a discussion (no related file):

Previously, jrobble (Jeff Robble) wrote…

Update these lines in the OIDC Connect Guide:

- Login settings:
    - Set "Valid redirect URIs" to
      `http://localhost:8080/workflow-manager/login/oauth2/code/provider`
    - Set "Valid post logout redirect URIs" to `http://localhost:8080/workflow-manager`
curl -H "Authorization: Bearer <access-token>" http://localhost:8080/workflow-manager/rest/actions

Done.


a discussion (no related file):

Previously, jrobble (Jeff Robble) wrote…

Please update REST-API.html:

            <td><span class='small-heading'>Base Path:</span></td>
            <td><span class='subheading-text'>/workflow-manager</span></td>

Done.


a discussion (no related file):

Previously, jrobble (Jeff Robble) wrote…

The custom system tests README has these lines that needs to be updated:

  • Then, start ActiveMQ, MySQL, Redis, and NodeManager.

Start ActiveMQ, MySQL, Redis, and NodeManager.

Also, the file still mentions mpf start --xtc. --xtc is now --xwfm.

Done.



docs/docs/Development-Environment-Guide.md line 243 at r1 (raw file):

Previously, jrobble (Jeff Robble) wrote…

Update this URL.

Done.


docs/docs/User-Guide.md line 16 at r1 (raw file):

Previously, jrobble (Jeff Robble) wrote…

Update this URL.

Done.

Copy link
Member

@jrobble jrobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 13 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @brosenberg42)

@brosenberg42 brosenberg42 merged commit a32027f into develop Dec 20, 2023
@brosenberg42 brosenberg42 deleted the feat/embedded-amq branch December 20, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants