Skip to content

Conversation

@brosenberg42
Copy link
Member

@brosenberg42 brosenberg42 commented Jan 25, 2024

@brosenberg42 brosenberg42 requested a review from jrobble January 25, 2024 17:27
@brosenberg42 brosenberg42 self-assigned this Jan 25, 2024
Copy link
Member

@jrobble jrobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 34 of 34 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @brosenberg42)


docs/docs/Roll-Up-Guide.md line 6 at r1 (raw file):

# Roll Up Overview

I pushed a jrobble/document-rollup branch. Please take a look and considering merging the changes into this one.

Among other things, I provided an example of roll up in the Overview section for clarity. Also, I moved the example JSON above the field definitions to give the reader more context up front. Additionally, I provided a "COLOR" example to give a second realistic use case.

Copy link
Member Author

@brosenberg42 brosenberg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 29 of 34 files reviewed, 1 unresolved discussion (waiting on @jrobble)


docs/docs/Roll-Up-Guide.md line 6 at r1 (raw file):

Previously, jrobble (Jeff Robble) wrote…

I pushed a jrobble/document-rollup branch. Please take a look and considering merging the changes into this one.

Among other things, I provided an example of roll up in the Overview section for clarity. Also, I moved the example JSON above the field definitions to give the reader more context up front. Additionally, I provided a "COLOR" example to give a second realistic use case.

Done.

Copy link
Member

@jrobble jrobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @brosenberg42)

@brosenberg42 brosenberg42 merged commit 796035e into develop Jan 29, 2024
@brosenberg42 brosenberg42 deleted the document-rollup branch January 29, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants