Skip to content

Conversation

@jrobble jrobble self-assigned this May 16, 2024
@jrobble jrobble changed the title Update version numbers to 9.0. Update release notes for R9.0.0. May 16, 2024
@jrobble jrobble requested a review from brosenberg42 May 23, 2024 03:09
Copy link
Member

@brosenberg42 brosenberg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, 3 unresolved discussions (waiting on @jrobble)


docs/docs/Release-Notes.md line 57 at r1 (raw file):

  for details.

<h3>Keyword Tagging Component Ouput</h3>

Change "Ouput" to "Output"


docs/docs/Release-Notes.md line 60 at r1 (raw file):

- Updated the Keyword Tagging Component to generate output in the same format as the  Transformer Tagging Component. For
  example, the output properties used to take the form `[INPUT] TRIGGER WORDS` and `[INPUT] TRIGGER WORDS OFFSET`:

Square brackets usually mean optional. For example, this is from the ln man page: ln [OPTION]... [-T] TARGET LINK_NAME. We normally use angle brackets to represent a place holder. The "Trigger Support" section use both of these conventions:
<prop_name>=<prop_value1>[;<prop_value2>...]


docs/docs/Release-Notes.md line 80 at r1 (raw file):

- Notice that in the above example the new output properties include the word `TRAVEL`. If trigger words are detected
  for other tags, such as `FINANCIAL` and `VEHICLE`, those words will be used in separate `TRIGGER WORDS` and
  `TRIGGER WORDS OFFSET` output properies.

Change "properies" to "properties"

Copy link
Member Author

@jrobble jrobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, 3 unresolved discussions (waiting on @brosenberg42 and @jrobble)


docs/docs/Release-Notes.md line 57 at r1 (raw file):

Previously, brosenberg42 wrote…

Change "Ouput" to "Output"

Done.


docs/docs/Release-Notes.md line 60 at r1 (raw file):

Previously, brosenberg42 wrote…

Square brackets usually mean optional. For example, this is from the ln man page: ln [OPTION]... [-T] TARGET LINK_NAME. We normally use angle brackets to represent a place holder. The "Trigger Support" section use both of these conventions:
<prop_name>=<prop_value1>[;<prop_value2>...]

Created this: openmpf/openmpf#1808


docs/docs/Release-Notes.md line 80 at r1 (raw file):

Previously, brosenberg42 wrote…

Change "properies" to "properties"

Done.

Copy link
Member Author

@jrobble jrobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 7 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jrobble)

Copy link
Member

@brosenberg42 brosenberg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 7 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jrobble)

@jrobble jrobble merged commit adccc0d into develop May 23, 2024
@jrobble jrobble deleted the feat/update-version-9.0 branch May 23, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants