RA-1816: Return of boolean expressions should not be wrapped into an …#84
Merged
debicki merged 2 commits intoopenmrs:masterfrom Nov 24, 2020
Merged
RA-1816: Return of boolean expressions should not be wrapped into an …#84debicki merged 2 commits intoopenmrs:masterfrom
debicki merged 2 commits intoopenmrs:masterfrom
Conversation
…'if-then-else' statement
HerbertYiga
reviewed
Nov 23, 2020
| return true; | ||
| } | ||
| return false; | ||
| return (isUserLocPropEnabled && Context.isAuthenticated() && Context.getUserContext().getLocationId() == null); |
debicki
reviewed
Nov 23, 2020
| return true; | ||
| } | ||
| return false; | ||
| return (isUserLocPropEnabled && Context.isAuthenticated() && Context.getUserContext().getLocationId() == null); |
Member
There was a problem hiding this comment.
Why not?
Suggested change
| return (isUserLocPropEnabled && Context.isAuthenticated() && Context.getUserContext().getLocationId() == null); | |
| return isUserLocPropEnabled && Context.isAuthenticated() && Context.getUserContext().getLocationId() == null; |
Member
Author
There was a problem hiding this comment.
Have addressed the comment and updated the PR
cc: @sacull
… 'if-then-else' statement
Member
|
It looks good to me now. ;) |
Member
|
@sacull just given you write access to this repository and the corresponding JIRA ticket. So feel free to do the needful. 😊 |
Member
|
Not again. You don't like me, @dkayiwa, if you keep giving me more work. ;) |
Member
|
@sacull you made me laugh my head off! Loool. 🤣 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://issues.openmrs.org/browse/RA-1816