Skip to content

CCLA-1028: Rename popType to entityType #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PrasadhNanjundan05 merged 1 commit into from
Sep 12, 2025
Merged

CCLA-1028: Rename popType to entityType #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions msa_sdk/pops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ def save_pops(self, data):
self.path = '{}'.format(self.api_path)
self._call_post(data)

def remove_pop(self, pop_type, vendor, name):
def remove_pop(self, entity_type, vendor, name):
"""
Remove a pop.

Parameters
----------
pop_type: type of pop
entity_type: type of pop
vendor: vendor of pop
name: name of pop

Expand All @@ -44,5 +44,5 @@ def remove_pop(self, pop_type, vendor, name):

"""
self.action = 'Remove Pop'
self.path = '{}?popType={}&vendor={}&name={}'.format(self.api_path, pop_type, vendor, name)
self.path = '{}?entityType={}&vendor={}&name={}'.format(self.api_path, entity_type, vendor, name)
self._call_delete()