Merged
Conversation
Collaborator
|
@paulromano thank you for the review and fixes, looks good to me. I'll run some local tests and incorporate the changes into the main PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@church89 I did a bit of refactoring on the
batchwise_prbranch for openmc-dev#2693. There were three major issues that needed to be fixed:_update_vecwas not correct; the vector that gets passed in is a rank-local list of atom densities, so it only needs to be updated on the current rank (not communicated across).I tried to make other improvements/simplifications. Let me know if you have any questions about the changes!