misc NPC natives and FCNPC parity#1206
Open
Knogle wants to merge 10 commits intoopenmultiplayer:masterfrom
Open
misc NPC natives and FCNPC parity#1206Knogle wants to merge 10 commits intoopenmultiplayer:masterfrom
Knogle wants to merge 10 commits intoopenmultiplayer:masterfrom
Conversation
Contributor
|
I compeletely don't understand the point in NPC_Give* functions. Why we should inflate main API with basically one-liner functions which could be done on Pawn side in some wrapper. The rest is kinda good for me 👍 |
Author
Ahoy, i've added those in order to match the function set provided by FCNPC, to be sort of a drop-in replacement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a batch of missing FCNPC NPC natives and callbacks on the server side.
Added callbacks:
Added functions:
This also adds the matching SDK exposure and keeps move mode documented as compatibility surface only where a real MapAndreas / ColAndreas backed implementation does not exist yet. For this case we have to consider some way to natively have Z data available for the server.
I've done the testing using the NPC test gamemode from @itsneufox https://github.com/itsneufox/NPC-bare-test-omp-gamemode