Merged
Conversation
commit: |
Closed
vicb
approved these changes
Feb 2, 2026
Contributor
vicb
left a comment
vicb
left a comment
There was a problem hiding this comment.
LGTM if it builds and passes the tests.
Do we actually need aliases ?
My (maybe outdated) feeling is that they only bring issues.
But ok to merge this for now for consistency and discuss later if needed
Collaborator
Author
Nah we don't need them, but there seems to be a lot of usage in aws. I imagine that a lot of imports might change as separate aws and core, so that might be a pathway to phasing out potentially |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@/)