Skip to content

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Dec 9, 2025

This PR update the c3 template to use the placeholders recently introduced in c3 (but not released yet).

The placeholders enabled to correctly setup the self binding name - it should match the worker name.

Notes:

  • The current c3 template overrides files from this template with those files
  • The changes have been tested with the current released version of c3
  • The changes have been tested with the future version of c3 (see this PR)
  • There is also a wrangler.jsonc template used when the project does not have one. It has been updated to use the same placeholder format and the corresponding code has been updated.

@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2025

⚠️ No Changeset found

Latest commit: d4dab2a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 9, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@opennextjs/cloudflare@1038

commit: d4dab2a

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I am not sure how this can work with the current C3? Won't you end up with a project that has an invalid wrangler.jsonc where the name is <WORKER_NAME>?

@vicb
Copy link
Contributor Author

vicb commented Dec 9, 2025

LGTM although I am not sure how this can work with the current C3? Won't you end up with a project that has an invalid wrangler.jsonc where the name is <WORKER_NAME>?

No because the wrangler.jsonc in this PR is not used by the current c3. c3 has its own version of wrangler.jsonc - that's the first bullet point in the description (arguably the link was wrong and I just fixed that).

And thanks for the review

@vicb vicb merged commit ac40c8c into main Dec 9, 2025
7 checks passed
@vicb vicb deleted the vicb/c3-template branch December 9, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants