fix: handle cacheComponents case not producing prerendered .rsc files #3275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
added
the
test all versions
Contributor
📊 Package size report 0.01%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
commented
Nov 26, 2025
Comment on lines
279
to
292
| // app router 404 pages are not in the prerender manifest for some next.js versions | ||
| // so we need to check for them manually if prerender manifest does not include it | ||
| if ( | ||
| !appRouterNotFoundDefinedInPrerenderManifest && | ||
| existsSync(join(ctx.publishDir, `server/app/_not-found.html`)) | ||
| ) { | ||
| const lastModified = Date.now() | ||
| const key = '/404' | ||
| const value = await buildAppCacheValue( | ||
| join(ctx.publishDir, 'server/app/_not-found'), | ||
| shouldUseAppPageKind, | ||
| ) | ||
| await writeCacheEntry(key, value, lastModified, ctx) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
We don't have meta.renderingMode here, but this case will only be hit on Next.js versions before vercel/next.js#82199 which happened earlier than removal of unneeded .prefetch.rsc so this case can assume that Next.js version would generate .prefetch.rsc files if we hit it
pieh
commented
Nov 26, 2025
| "test": { | ||
| "dependencies": { | ||
| "next": "canary" | ||
| "next": "canary || >=16.0.0" |
Contributor
Author
There was a problem hiding this comment.
We were not running those tests on latest even tho cacheComponents can be used on stable releases.
pieh
commented
Nov 26, 2025
|
|
||
| if (versionConstraints) { | ||
| // We need to be able to define constraint such as "canary or >=16.0.0" for testing features that might have | ||
| // canary-only support (you can only even try them on canary releases) that later on get promoted to be usable in stable |
Contributor
Author
There was a problem hiding this comment.
Some additional context about "canary-only" support - Next.js tends to have checks like so https://github.com/vercel/next.js/blob/f54479b9dfea3cb9b092a1e11020db0d438454cc/packages/next/src/server/config.ts#L401-L408 or https://github.com/vercel/next.js/blob/v15.5.6/packages/next/src/server/config.ts#L371-L382 (depending on version)
So for features like this we kind of need a way to check if it's canary, but there is not a good way to check this with some kind of semver range, so we kind of need a special case for it. We already did have one, but it didn't support alternatives, which is what this change is adding, so we could continue to be able to run tests on previous canaries + newer stable versions
mrstork
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In recent Next.js canaries there was a cleanup of
.prefetch.rscfiles for thecacheComponentscase ( vercel/next.js#86100 ). We currently are expecting all app router pages to have either.rscor.prefetch.rscfile generated, but with the change this is no longer true. This makes .rsc optional for PPR pages (note that we will still use them if they exist to continue to behave same way with Next.js versions prior to that change).Documentation
Tests
Tests were slightly updated to not expect
/404prerendered cache entries blobs for Next.js newer than vercel/next.js#82199 . Existing tests for 404 cases continue to pass.Relevant links (GitHub issues, etc.) or a picture of cute animal