Skip to content

test: fix 'after' fixture next version range #3324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrstork merged 5 commits into from
Dec 15, 2025
Merged

test: fix 'after' fixture next version range #3324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f69f7b9
test: fix 'after' fixture next version range
pieh Dec 15, 2025
dda370b
test: cleanup function dist dir in integration tests
pieh Dec 15, 2025
ef1c7e0
test: don't prepare dynamic-cms fixture as it's not used for integrat…
pieh Dec 15, 2025
b047f44
Revert "test: cleanup function dist dir in integration tests"
pieh Dec 15, 2025
fc159e0
Merge branch 'main' into test/fix-after-fixture-reqs
pieh Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/fixtures/after/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
},
"test": {
"dependencies": {
"next": "15.1.11"
"next": ">=15.1.0"
}
}
}
Comment on lines 15 to 20
Copy link
Contributor Author

@pieh pieh Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This defines when RESOLVED_NEXT_VERSION will be used to install version that is different in package.json#depencies.next - because of the pinning this was never satisfied, so it was always installing latest which requires node@20 and cause just build errors when testing v15 (15.5.9).

This is meant to mimic range used in test themselves - in particular here it needs to match

opennextjs-netlify/tests/e2e/after.test.ts

Lines 5 to 6 in fb87ac7

// This test is only for Next.js >=15.1.0 that has stable after() support
if (nextVersionSatisfies('>=15.1.0')) {

1 change: 1 addition & 0 deletions tests/prepare.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ const e2eOnlyFixtures = new Set([
'after',
'cli-before-regional-blobs-support',
'dist-dir',
'dynamic-cms',
Copy link
Contributor Author

@pieh pieh Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related, but noticed we do prepare this fixture for integration tests, but we only use them in e2e - so prebuilding is not needed (and might safe some disk usage which has some problems now)

'middleware-i18n-excluded-paths',
'middleware-node-runtime-specific',
'middleware-static-asset-matcher',
Expand Down
Loading