Update the ECR cron job to support the node architecture#30
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the ECR credential refresh CronJob/Job Helm templates to download an architecture-appropriate kubectl binary at runtime, enabling the job to run on non-amd64 nodes (e.g., arm64) as part of OPS-4266.
Changes:
- Detect node architecture via
uname -mand map it to Kubernetes download arch strings. - Download
kubectland its.sha256file for the detected architecture, then verify the checksum. - Apply the same update to both the recurring CronJob and the post-install/upgrade init Job.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Validate architecture is amd64 or arm64 before downloading kubectl - Use curl -fSL instead of -sLO to fail on HTTP errors (e.g., 404) - Both CronJob and init Job updated Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
maor-rozenfeld
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OPS-4266