Refactor azure sub dropdown property and add multi select dropdown#1604
Refactor azure sub dropdown property and add multi select dropdown#1604bigfluffycookie merged 4 commits intomainfrom
Conversation
bigfluffycookie
changed the title
bigfluffycookie
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Azure subscription dropdown property system to support both single and multi-select modes. The refactoring extracts common logic into reusable helper functions and introduces configuration-based dropdown creation.
Key changes:
- Introduced a configuration-based approach for subscription dropdowns with
SubscriptionDropdownConfiginterface - Added support for multi-select subscription dropdowns alongside existing single-select functionality
- Extracted common logic into helper functions (
fetchSubscriptionsFromHostSession,createSubscriptionDropdown,getSubscriptionsDropdown)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| export const subDropdown = Property.DynamicProperties({ | ||
| displayName: '', | ||
| export interface SubscriptionDropdownConfig { |
There was a problem hiding this comment.
its an attempt to avoid the duplication of 2 basically identical properties, the alternative is to just copy paste the subDropdown implementation and simply using staticmultiselect instead of staticdropdown but i like this a bit better
|
Part of OPS-2860